Commentaires sur : Patching Cacti Threshold plugin for Nagios notification

Par : justin

justin — Fri, 19 Sep 2008 20:01:46 +0000

Problem: used the latest ver of cacti, skipped the ldap part and downloaded the 0.3.4 Thold version linked above and applied the patch. Results:

1 out of 5 hunks FAILED — saving rejects to file check-thold.php.rej
patching file setup.php
Hunk #1 FAILED at 629.
1 out of 1 hunk FAILED — saving rejects to file setup.php.rej
patching file thold-functions.php
patching file thold.php
Hunk #2 FAILED at 481.
1 out of 2 hunks FAILED — saving rejects to file thold.php.rej
patching file thold_templates.php
Hunk #2 FAILED at 605.
1 out of 2 hunks FAILED — saving rejects to file thold_templates.php.rej
[root@nagios01 thold]# patch -p1 -N < cacti-thold.patch
patching file check-thold.php
Hunk #5 FAILED at 264.
1 out of 5 hunks FAILED — saving rejects to file check-thold.php.rej
patching file setup.php
Hunk #1 FAILED at 629.
1 out of 1 hunk FAILED — saving rejects to file setup.php.rej
patching file thold-functions.php
patching file thold.php
Hunk #2 FAILED at 481.
1 out of 2 hunks FAILED — saving rejects to file thold.php.rej
patching file thold_templates.php
Hunk #2 FAILED at 605.
1 out of 2 hunks FAILED — saving rejects to file thold_templates.php.rej

I manually added the changes to setup.php per the diff. The rest of the failed hunks have .rej files like this:

***************
*** 584,587 ****
print “\n”;
}

- ?>
— 605,608 —-
print “\n”;
}

+ ?>

to me that looks like it’s not intended to be an actual change, but maybe just a code validation check.

The end result is that when I click Data Sources, the rows under the Templates column is no longer a hyperlink.

Par : Prune

Prune — Tue, 08 Jan 2008 09:51:36 +0000

As you can see in a previous comment from Jimmy, it should be included in the next version.
For the moment it’s still actual.
Thanks for the comment.

Par : mastrboy

mastrboy — Tue, 08 Jan 2008 08:38:04 +0000

many thanks, been looking for something like this.. Have tried to request it many times in the cactiusers forum, they just ignore my post :p

Par : Idetrorce

Idetrorce — Sat, 15 Dec 2007 22:20:33 +0000

very interesting, but I don’t agree with you
Idetrorce

Par : Jimmy

Jimmy — Wed, 21 Nov 2007 15:50:38 +0000

Main reason it has not been added to the main tree is that the future version I am working on makes it completely irrelevant. Thold v1.0 has the option to allow script execution, paging, or anything else (you can write another plugin to hook into thold to add support for whatever you want).

As it is now, the patch is for a specialized use, for people that use nagios. I’m trying not to add too many features to the current stable version until I can start back porting a lot of the neat changes in v1.0.

Par : Prune

Prune — Fri, 16 Nov 2007 08:32:14 +0000

Yes

Maybe next when I have some time. I don’t know why nobody want’s to add this kind of feature to the main tree… this is simple and pretty usefull.

I let you know as soon as it’s done.

Par : Robin

Robin — Fri, 16 Nov 2007 02:41:33 +0000

Any chance you will update this for the most current cacti and thold plugins, cacti-0.8.7 and thold-0.3.7 sometime soon?