Commentaires sur : Patching Cacti Threshold plugin for Nagios notification

Par : TheWitness

TheWitness — Sat, 17 Sep 2011 17:24:25 +0000

Placing the patch in the Cacti bug’s database is the way to report both enhancements and bug. http://bugs.cacti.net

Par : Prune

Prune — Fri, 06 Aug 2010 16:08:54 +0000

People from Cacti, Plugins framework for Cacti and specialy the Threshold plugin dev team DONT WANT to add this feature. They argue they are « in the process or re-writing » the whole thing… In the meantime, 3 years now, you just can’t have this option…
Or you can use my patch, which is not maintained as I’m not using it anymore… (I’m doing something else than monitoring)

Par : Adners Holm

Adners Holm — Thu, 05 Aug 2010 13:46:02 +0000

Thanks for the patch. Despite this being a patch for a much older version of (everything) that I am running, this still doesn’t exist in thold. Hopefully I can scrub it up a tad to make it work for us here.

2 and a half years to add this to main branch?

Par : Prune

Prune — Mon, 26 Jan 2009 08:10:06 +0000

threshold plugin is working fine. Hacking it so it can talk to Nagios was what I needed, and I did it the easyiest way I found.
New releases of Cacti sure break the code given here. I will have a look when I upgrade to new Nagios and new Cacti.
You’re free to re-write the code if you need it

Par : quequotion

quequotion — Mon, 26 Jan 2009 07:54:28 +0000

this post makes it all sound so easy… i know i’m not the only person who couldn’t get the latest nagios, cacti, or thold running without hacking my way through several dozen bugs and installing countless dependencies….
does any of this software actually work for anyone?
imho, the code needs a complete overhaul.

Par : justin

justin — Fri, 19 Sep 2008 20:01:46 +0000

Problem: used the latest ver of cacti, skipped the ldap part and downloaded the 0.3.4 Thold version linked above and applied the patch. Results:

1 out of 5 hunks FAILED — saving rejects to file check-thold.php.rej
patching file setup.php
Hunk #1 FAILED at 629.
1 out of 1 hunk FAILED — saving rejects to file setup.php.rej
patching file thold-functions.php
patching file thold.php
Hunk #2 FAILED at 481.
1 out of 2 hunks FAILED — saving rejects to file thold.php.rej
patching file thold_templates.php
Hunk #2 FAILED at 605.
1 out of 2 hunks FAILED — saving rejects to file thold_templates.php.rej
[root@nagios01 thold]# patch -p1 -N < cacti-thold.patch
patching file check-thold.php
Hunk #5 FAILED at 264.
1 out of 5 hunks FAILED — saving rejects to file check-thold.php.rej
patching file setup.php
Hunk #1 FAILED at 629.
1 out of 1 hunk FAILED — saving rejects to file setup.php.rej
patching file thold-functions.php
patching file thold.php
Hunk #2 FAILED at 481.
1 out of 2 hunks FAILED — saving rejects to file thold.php.rej
patching file thold_templates.php
Hunk #2 FAILED at 605.
1 out of 2 hunks FAILED — saving rejects to file thold_templates.php.rej

I manually added the changes to setup.php per the diff. The rest of the failed hunks have .rej files like this:

***************
*** 584,587 ****
print « \n »;
}

- ?>
— 605,608 —-
print « \n »;
}

+ ?>

to me that looks like it’s not intended to be an actual change, but maybe just a code validation check.

The end result is that when I click Data Sources, the rows under the Templates column is no longer a hyperlink.

Par : Prune

Prune — Tue, 08 Jan 2008 09:51:36 +0000

As you can see in a previous comment from Jimmy, it should be included in the next version.
For the moment it’s still actual.
Thanks for the comment.

Par : mastrboy

mastrboy — Tue, 08 Jan 2008 08:38:04 +0000

many thanks, been looking for something like this.. Have tried to request it many times in the cactiusers forum, they just ignore my post :p

Par : Idetrorce

Idetrorce — Sat, 15 Dec 2007 22:20:33 +0000

very interesting, but I don’t agree with you
Idetrorce

Par : Jimmy

Jimmy — Wed, 21 Nov 2007 15:50:38 +0000

Main reason it has not been added to the main tree is that the future version I am working on makes it completely irrelevant. Thold v1.0 has the option to allow script execution, paging, or anything else (you can write another plugin to hook into thold to add support for whatever you want).

As it is now, the patch is for a specialized use, for people that use nagios. I’m trying not to add too many features to the current stable version until I can start back porting a lot of the neat changes in v1.0.